Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Prevent some folders from listing in template fieldtype #10031

Merged
merged 9 commits into from
May 27, 2024

Conversation

peimn
Copy link
Contributor

@peimn peimn commented May 9, 2024

When incorporating views as a git submodule and setting up a node project, you'll observe that the 'template' field type lists all folders, including 'node_modules,' which is an undesired behavior.

@duncanmcclean duncanmcclean changed the title [5.x] prevent some folders from listing in template FT [5.x] Prevent some folders from listing in template fieldtype May 10, 2024
Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed some issues even after your changes with unexpected items being shown, like incorrect paths etc.

I've added tests, corrected the issues, and cleaned things up a bit.

Thanks!

@peimn
Copy link
Contributor Author

peimn commented May 24, 2024

Thank you! It appears that more testing is required. I will conduct additional tests to ensure everything is in order before pushing the changes.

@jasonvarga jasonvarga merged commit 46b4d39 into statamic:5.x May 27, 2024
16 checks passed
@jasonvarga
Copy link
Member

It's okay, we got it. Thanks!

@peimn
Copy link
Contributor Author

peimn commented May 27, 2024

Thank you!

@peimn peimn deleted the fix/template-list branch May 27, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants