[5.x] Add failing test for issue caused by PR #9585 #10061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerni
changed the title
|
Thanks for the failing test! I'll also poke around with this one this week 👍 |
|
Thanks, John. Appreciate! ❤️ |
|
Would be nice to see this fixed, so I can update to Statamic 5 after @aerni updates his Advanced SEO plugin ;) |
|
I've updated this PR to also clear the internal blueprint handle cache when mutating fields/adjusting items about the blueprint itself. This will resolve the issue with making multiple changes not regenerating the fields, but continue to help prevent regenerating fields each time parents/etc. are set |
|
I can confirm that this fixes the issue in my Advanced SEO addon. Before: After: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a failing test to illustrate the issue caused by PR #9585. That PR makes it impossible to manipulate a blueprint multiple times during the same request. This is an issue when you are relying on manipulating the blueprint at different stages in an
EntryBlueprintFoundlistener.Jason said: I don't see any noticeable difference in load times, but this PR is only a handful of lines now so I don't think it hurts. So, maybe it's not a big deal to revert the PR altogether?
Else, we might need to find a way to opt-out of the fields cache. Or maybe this is simply a bug that can be fixed while retaining the caching.