Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Dark Mode for Control Panel #9929

Closed
wants to merge 11 commits into from
Closed

[4.x] Dark Mode for Control Panel #9929

wants to merge 11 commits into from

Conversation

peimn
Copy link
Contributor

@peimn peimn commented Apr 18, 2024

Carefully curated hues designed to ease eye strain during nighttime work sessions, which often dominate our schedules. 馃寶馃寖

@jasonvarga
Copy link
Member

Awesome

@duncanmcclean duncanmcclean changed the title [4.x] dark mode for control panel [4.x] Dark Mode for Control Panel Apr 24, 2024
Copy link
Member

@duncanmcclean duncanmcclean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you're able, can you merge 5.x into this branch and update the target branch for this PR?

There's a bunch of merge conflicts and I didn't want to mess anything up 馃檪

@jasonvarga
Copy link
Member

I'm happy to resolve those conflicts, @peimn.

@peimn
Copy link
Contributor Author

peimn commented May 14, 2024

I've completed the merge to version 5.x, improved the dark mode, and resolved several bugs. I'm now ready to push the updates.

@jasonvarga
Copy link
Member

Ok, go for it!

@peimn
Copy link
Contributor Author

peimn commented May 14, 2024

Sorry! It took me some time to double-check everything to ensure it was tidy because I made other changes and didn't want them to be merged. I've pushed dark-mode merge for 5.x in another pull request #10073

@duncanmcclean
Copy link
Member

Thanks! I'll close this in favour of #10073.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants