Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Ability to set max file size on an asset container #9966

Conversation

edalzell
Copy link
Contributor

@@ -17,6 +17,7 @@ public function keys()
'search_index',
'api_url',
'assets',
'max_size',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonvarga I don't understand why this is needed, but without it the tests don't pass. With it, unrelated tests fail.

@edalzell edalzell marked this pull request as ready for review May 1, 2024 20:06
@edalzell
Copy link
Contributor Author

edalzell commented May 1, 2024

This works for me, but I'm having some trouble with the tests (see comment above). Guidance/help would be appreciated.

@edalzell edalzell changed the base branch from 4.x to 5.x May 9, 2024 18:35
@edalzell edalzell changed the title [4.x] Ability to set max file size on an asset container [5.x] Ability to set max file size on an asset container May 9, 2024
@edalzell edalzell changed the base branch from 5.x to 4.x May 16, 2024 20:35
@edalzell edalzell changed the base branch from 4.x to 5.x May 16, 2024 20:35
@edalzell edalzell mentioned this pull request May 16, 2024
@jasonvarga
Copy link
Member

I'd rather be able to add validation rules to a container.

Then you can add a max rule to it.

See:
statamic/ideas#2
statamic/ideas#619

@jasonvarga jasonvarga closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Max File Upload Size for Assets Container
2 participants