Skip to content
This repository has been archived by the owner on Oct 7, 2022. It is now read-only.

Switch wallet tsconfig to use esnext module #614

Merged
merged 4 commits into from Dec 3, 2019
Merged

Conversation

snario
Copy link
Collaborator

@snario snario commented Dec 3, 2019

In order to use dynamic imports, we need to use the import(...) syntax. TypeScript doesn't know how to handle this with commonjs, so we need to use esnext.

In order to use WebAssembly in the browser we need to use dynamic imports.

In order to use pure-evm, we need to use WebAssembly, which means we need dynamic imports.

The integration tests use ts-node, which uses Node.js, which can't handle ES modules. See TypeStrong/ts-node#436.

So, I need to use commonjs for the puppeteer/funding.ts test script. Note that this is just for the test script, which launches a browser, which runs the webpack output, which was built from the TypeScript source compiled using esnext.

@snario snario requested a review from lalexgap December 3, 2019 02:23
@snario
Copy link
Collaborator Author

snario commented Dec 3, 2019

I noticed webpack's stats.warningsFilter doesn't seem to work. Also it doesn't work in the browser at all: webpack-contrib/webpack-hot-client#94. That might be an issue.

Also jsonrpc-lite started raising this warning: teambition/jsonrpc-lite#15

@snario
Copy link
Collaborator Author

snario commented Dec 3, 2019

Ugh I think this might be blocked on #593 because the hub uses ts-node and imports the wallet for certain things.

Fixed

@tomclose tomclose merged commit bf55284 into master Dec 3, 2019
@tomclose tomclose deleted the liam-wallet-esnext branch December 11, 2019 11:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants