This repository has been archived by the owner on Oct 7, 2022. It is now read-only.
Switch wallet tsconfig to use esnext module #614
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use dynamic imports, we need to use the
import(...)
syntax. TypeScript doesn't know how to handle this withcommonjs
, so we need to useesnext
.In order to use WebAssembly in the browser we need to use dynamic imports.
In order to use
pure-evm
, we need to use WebAssembly, which means we need dynamic imports.The integration tests use
ts-node
, which uses Node.js, which can't handle ES modules. See TypeStrong/ts-node#436.So, I need to use
commonjs
for thepuppeteer/funding.ts
test script. Note that this is just for the test script, which launches a browser, which runs the webpack output, which was built from the TypeScript source compiled usingesnext
.