Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue with EmittedFrom sometimes not being able to infer the snapshot types from machines #3783

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Jan 24, 2023

I noticed this problem when working on #3778

@changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2023

🦋 Changeset detected

Latest commit: 2a13238

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
xstate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

'xstate': patch
---

Fixed an issue with `EmittedFrom` sometimes not being able to infer the snapshot types from machines.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this sentence could be simplified/rephrased by a native speaker: @davidkpiano :!wink: :!wink:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@ghost
Copy link

ghost commented Jan 24, 2023

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2a13238:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

@Andarist Andarist merged commit b68f0e8 into main Jan 24, 2023
@Andarist Andarist deleted the andarist/fix-emittedfrom-machines branch January 24, 2023 16:26
@github-actions github-actions bot mentioned this pull request Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants