[v5] React .provide support
#3947
Conversation
🦋 Changeset detectedLatest commit: ab5bb51 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ab5bb51:
|
| TMachine['__TResolvedTypesMeta'] | ||
| > extends false | ||
| ? { | ||
| options: InternalMachineImplementations< |
There was a problem hiding this comment.
<Provider machine={someMachine.provide()} /> is workable but i think that it makes it a little bit awkward because we are repeating someMachine here - we already given it to create the Provider , it's available internally as a closure, types are bound to it === it looks like a chore that we still require it to be used directly here.
The best idea I have so far to solve this is for the behavior to somehow declare it's available options. This way the interpreter-level stuff could accept those options in a generic way.
There was a problem hiding this comment.
Smth like this could work
<Context.Provider machine={machine => machine.provide({})}>{null}</Context.Provider>That's quite a bit of machine in here though 🤔
| @@ -32,40 +29,21 @@ export function useIdleInterpreter( | |||
| ) { | |||
| const [initialMachine] = useState(machine); | |||
|
|
|||
| if (getMachine !== initialMachine) { | |||
| if (getMachine.config !== initialMachine.config) { | |||
There was a problem hiding this comment.
Similarly, .config is super machine-specific thing. If we want to make useInterpret to accept just any actor then it should be possible to check smth like this on just any actor type.
There was a problem hiding this comment.
To solve this we could do this:
const config = () => Promise.resolve('')
const behavior = fromPromise(config)
behavior.config === configThere was a problem hiding this comment.
Good call, I'll think about how we can generalize this.
There was a problem hiding this comment.
Added to 4659f45 - let me know what you think. Might need help on this
…hine` and `useInterpret` (#4007) * Removed the ability to pass a factory function as argument to `useMachine` and `useInterpret` * Update .changeset/fifty-dingos-appear.md
No description provided.