-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge createActorContext
options with Provider options
#4695
Merge createActorContext
options with Provider options
#4695
Conversation
🦋 Changeset detectedLatest commit: 80b1223 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 80b1223:
|
|
||
const App = () => { | ||
return ( | ||
<SomeContext.Provider options={{ input: 10 }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test doesn't check that those options
here were used - if the test is meant to check the merging behavior then we should have assertions validating that both of those are preserved somehow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improved the test to check that count: 10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already testing the top-level option by reading the events
array
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
Options in
createActorContext
are now properly merged with provider options. Previously, provider options replaced the actor options.