Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge createActorContext options with Provider options #4695

Merged
merged 5 commits into from
Jan 23, 2024

Conversation

davidkpiano
Copy link
Member

Options in createActorContext are now properly merged with provider options. Previously, provider options replaced the actor options.

const { inspect } = createBrowserInspector();

const SomeContext = createActorContext(someMachine, { inspect });

// ...
// Options are now merged:
// { inspect: inspect, input: 10 }
<SomeContext.Provider options={{ input: 10 }}>
  {/* ... */}
</SomeContext.Provider>;

Copy link

changeset-bot bot commented Jan 22, 2024

🦋 Changeset detected

Latest commit: 80b1223

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@xstate/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codesandbox-ci bot commented Jan 22, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 80b1223:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration


const App = () => {
return (
<SomeContext.Provider options={{ input: 10 }}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test doesn't check that those options here were used - if the test is meant to check the merging behavior then we should have assertions validating that both of those are preserved somehow.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved the test to check that count: 10

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already testing the top-level option by reading the events array

davidkpiano and others added 3 commits January 23, 2024 05:23
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
@davidkpiano davidkpiano merged commit 52900a0 into main Jan 23, 2024
2 checks passed
@davidkpiano davidkpiano deleted the davidkpiano/inspector-with-createactorcontext branch January 23, 2024 15:49
@github-actions github-actions bot mentioned this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants