-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build on FreeBSD by updating foomo/simplecert dependency. #176
base: dev
Are you sure you want to change the base?
Conversation
Fix build on FreeBSD by updating foomo/simplecert dependency.
Fix build on FreeBSD by updating foomo/simplecert dependency.
Looks sensible to me. |
Thanks @adamboutcher . Can we have this reviewed and committed? |
hey @yonas, can you "un-delete" your fork+the branch this PR is coming from? github still shows everything fine, but I can't actually check out the changes to test them D: I know github can restore deleted branches, not sure about repos. no worries if it doesn't work, you (or I) can always just put the changes on a new branch + make a new PR |
@jemand771 Done. |
|
@jemand771 Are you happy with this? |
nu, the build fails (at least for me) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see previous comments
(funnily enough github requires you to put text here)
hey @yonas, can you check whether builds on the dev branch are still broken for you? there have been a lot of somewhat chaotic changes recently, this might just have fixed itself |
@jemand771 Still an issue:
|
I don't know go but this looks like its an issue with their package? I'm possibly wrong though so feel free to explain it to me. |
@adamboutcher Some kind of bug in foomo/simplecert that got fixed in the latest version. |
Do all the dependencies need updating or just simple cert? It looks like previously the changes broke something for @jemand771 so if we can drop this to just the one dep it should be a happier merge? |
@adamboutcher Yes, a bunch of other dependencies need to be updated as well. To get around the issue @jemand771 mentioned, I wrote a script to download those modules and run
|
This updates the foomo/simplecert dependency in go.mod and go.sum.