Allow to disable graphs and set number of days of historical data for services

[CSharpRU]

Hello there,

I've added ability to switch off/on graphs for services and ability to set number of days of historical data to retrieve from backend for services:

Tested locally, all new features work as intended. Please advice in code, logic or missed things that I need to fix/add :)

Fixes? #96

[jemand771]

haven't looked at all of the code yet, but as some quick feedback:

• your PR has big whitespace changes in some files (diff viewer shows big diff but nothing changed) - maybe you can fix those so it's easier to see what you did
• I like the idea of globally disabling all graphs, but I could also see someone wanting to hide them on a per-service basis. how do you feel about that idea?
• nitpick: I'd probably call the option "show graphs" or "enable graphs" and have it on by default instead of "disables graphs" and having it off by default :b

[CSharpRU]

haven't looked at all of the code yet, but as some quick feedback:

• your PR has big whitespace changes in some files (diff viewer shows big diff but nothing changed) - maybe you can fix those so it's easier to see what you did
• I like the idea of globally disabling all graphs, but I could also see someone wanting to hide them on a per-service basis. how do you feel about that idea?
• nitpick: I'd probably call the option "show graphs" or "enable graphs" and have it on by default instead of "disables graphs" and having it off by default :b

Thanks, I’ll look into that and change the code.

[CSharpRU]

Renamed disable graphs to show graphs and set enabled by default:

Added ability to disable graph per service:

• your PR has big whitespace changes in some files (diff viewer shows big diff but nothing changed) - maybe you can fix those so it's easier to see what you did

I don't see any issues in VS Code or GitHub, can you give me an example or screenshot? :)

[jemand771]

nevermind on the whitespace, those are all good. you indented a lot of things because NumberOfDaysForService is longer than all of the other settings, but that's fine
(I initially thought this might be a line ending or tabs/spaces thing)

[CSharpRU]

I think that's it then or should I add something else?

[CumpsD]

This is a nice feature!

[bretdavi89]

Not to be that guy, but wondering what the status of reviewing/merging this PR is? This would be a very nice feature to have.

[bretdavi89]

Pulled this into my fork and noticed that the status bar doesn't appropriately resize for shorter day ranges. E.g. had this set to 14 days:

So appears that scaling of those elements needs to occur to fill the row

[CSharpRU]

Pulled this into my fork and noticed that the status bar doesn't appropriately resize for shorter day ranges. E.g. had this set to 14 days:

So appears that scaling of those elements needs to occur to fill the row

I haven't touched frontend for 8 years, so if anyone can help that'd be great :D

[Appel-flappen]

This would be a great feature, also would fix the issue on mobile where the little status pills become tiny and antialias weird, giving different sizes.

(oops, didn't mean to review and accept)

[Grunticus03]

Sooo....can this be merged?