Make all services and groups available via the API (#69) #210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a needed fix, because external services or scripts should have access to all data. If there is a use case where an API token should not access private data, different token permissions should probably be implemented.
I tested this the following way:
Of course, this should be pointed out in the release notes.
Testing locally can be done by building the binary. With Go and Node installed, run
make build
. Then start Statping with./statping
.API testing can be done by setting an API secret right before starting Statping with
export API_SECRET=super-secret-token
. In a tool like Insomnia, you can point tohttp://localhost:8080/api/services
with the secret as a Bearer token.