Refactor use of EventEmitter to work with Node versions 6 and above #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 7, 2017
|
@pathzzrd is there something blocking this? |
|
Why is this not merged yet? |
|
Any updates on this? We're moving most of our projects to 8+. |
|
A smaller patch has already been merged (and works for me with Node 9), but a new release has not yet been made. |
|
Any chance to merge it soon? |
|
In the meanwhile I sent a patch for the FreeBSD Port. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change that will allow statsd to be run on Node version 6 and up. All test pass in multiple version of Node v6 and in the latest LTS v8.9.1