-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kitty support and update to node 16 #79
Open
IntrepidPig
wants to merge
8
commits into
stayradiated:master
Choose a base branch
from
IntrepidPig:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates various dependencies to their latest versions and updates a small amount of code to be compatible with the new versions. Notably this updates node-sass and the collection of gulp-related packages, both of which are prone to compatibility issues with unsupported versions of nodejs. This commit was not done artfully. I have very little experience with the JS ecosystem, all I really did was follow error messages and stack overflow answers until it ran successfully. A more experienced person may want to review this changes with more scrutiny than I gave.
iss been 2 years can this b pulled i want kitty support |
So real |
I dunno this fixes some cross platform issues or something
yarn wasn't working to build for some reason it kept using an old node-gyp version
I think this fixes more build issues around node-gyp
You can clone the fork, do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to add support for the kitty terminal, I ended up also updating dependencies and related code to work with node 16. As I am not very familiar with the JS ecosystem, it is quite possible this pull request features some major errors, in which class I will do my best to fix them as necessary.