[Fix] jsx-curly-brace-presence: bail out on JSX inside props, for now

Fixes jsx-eslint#2423.
stefan-wullems · Nov 30, 2019 · 6ac71e9 · 6ac71e9
1 parent 1c3b5a6
commit 6ac71e9
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 5 deletions.
diff --git a/lib/rules/jsx-curly-brace-presence.js b/lib/rules/jsx-curly-brace-presence.js
@@ -114,21 +114,26 @@ module.exports = {
      * @param {ASTNode} JSXExpressionNode - The AST node with an unnecessary JSX expression
      */
     function reportUnnecessaryCurly(JSXExpressionNode) {
+      const expression = JSXExpressionNode.expression;
+      const expressionType = expression.type;
+      const parentType = JSXExpressionNode.parent.type;
+      const isJSX = jsxUtil.isJSX(expression);
+
+      if (parentType === 'JSXAttribute' && isJSX) {
+        return;
+      }
+
       context.report({
         node: JSXExpressionNode,
         message: 'Curly braces are unnecessary here.',
         fix(fixer) {
-          const expression = JSXExpressionNode.expression;
-          const expressionType = expression.type;
-          const parentType = JSXExpressionNode.parent.type;
-
           let textToReplace;
           if (parentType === 'JSXAttribute') {
             textToReplace = `"${expressionType === 'TemplateLiteral' ?
               expression.quasis[0].value.raw :
               expression.raw.substring(1, expression.raw.length - 1)
             }"`;
-          } else if (jsxUtil.isJSX(expression)) {
+          } else if (isJSX) {
             const sourceCode = context.getSourceCode();
 
             textToReplace = sourceCode.getText(expression);

diff --git a/tests/lib/rules/jsx-curly-brace-presence.js b/tests/lib/rules/jsx-curly-brace-presence.js
@@ -304,6 +304,12 @@ ruleTester.run('jsx-curly-brace-presence', rule, {
       `,
       parser: parsers.BABEL_ESLINT,
       options: [{children: 'never'}]
+    },
+    {
+      code: `
+        <MyComponent p={<Foo>Bar</Foo>}>
+        </MyComponent>
+      `
     }
   ],