-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed reference to localhost from swagger #336
Conversation
Yes please, I have a remote kubernetes cluster so I can't use swagger UI due to this bug. |
@michaelkebe can you please rebase and fix the conflicts. Thanks |
Will do in 2 weeks. |
9386501
to
d0cc9cd
Compare
Looks like c305843 has broken some swagger stuff.
Trying to replace some references to
But there are still some references to |
Now it is possible to use the swagger webinterface running on a host other than localhost e.g. in docker or kubernetes. Removed the @host line from pkg/api/server.go and ran make swagger. Fixes probably stefanprodan#179
d0cc9cd
to
1619150
Compare
Fixed it. |
@stefanprodan There were no other references to Fixed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @michaelkebe 🏅
Now it is possible to use the swagger webinterface running on a host other than localhost e.g. in docker or kubernetes.
Removed the @host line from pkg/api/server.go and
ran make swagger.
Fixes: #179