Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On the fly sample swapping is not implemented #22

Open
blaqmajik opened this issue Jan 30, 2019 · 6 comments
Open

On the fly sample swapping is not implemented #22

blaqmajik opened this issue Jan 30, 2019 · 6 comments

Comments

@blaqmajik
Copy link

The lead coming in at position 07 remains 'stale' and it seems it's not re-triggered in the same way it is when you use ProTracker - the alternating "0a, 0b, 0c, 0d, 0e"s in the sample/instrument column should switch to the respective sample, even when there is no new note triggered.

@8bitbubsy
Copy link

This is called sample swapping and is not trivial to implement correctly. Many trackers didn't even support it outside of NoiseTracker/ProTracker.

@steffest
Copy link
Owner

steffest commented Jan 30, 2019

Yes, that "on the fly sample swapping" thing is an annoying one.
That's one of these things that were there in Protracker 1 and 2, but not anymore in Protracker 3 and beyond. (And also not in Fasttracker)
I'm still pondering if I should implement it ... I tend to lean to "no" - 100% compatiblity is not really the goal - or even achievable ... that's something only @8bitbubsy can do!

@8bitbubsy
Copy link

100% compatiblity is not really the goal - or even achievable ... that's something only @8bitbubsy can do!

Hehe, the only reason I can get it 100% right is because I'm porting original replayers instead of writing my own. It's a challenge to get these old quirks right when you roll your own replayer, that's for sure...

@blaqmajik
Copy link
Author

blaqmajik commented Jan 30, 2019

I'm still pondering if I should implement it ...

Fair point. It is used in a lot of chiptunes, though.

And not just in obscure ones but in absolute crack intro classics like "Digital Bass-Line" from Emax, for example.

@steffest steffest changed the title Atominus by Maza (Protracker) sounds off On the fly sample swapping is not implemented Feb 1, 2019
@bryc
Copy link

bryc commented Feb 1, 2019

Sample swapping works in NT1/2 and PT1/2. but doesn't work in PT3 or FT1/2. I used to use that trick but went back to manually put in notes where they should be for maximum player compatibility. Not like you are saving any bytes by omitting them..

@8bitbubsy
Copy link

Yep, PT3 is known for breaking sample swapping. Did you know that sample swapping actually works in Sound Blaster mode in Scream Tracker 3? Little known fact. It does however not work the same way as ProTracker (where it will switch to the new sample after one cycle of the current sample has been done).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants