Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release_on_start task configuration #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

malthejorgensen
Copy link

@malthejorgensen malthejorgensen commented Jun 10, 2022

Adds release_on_start to the task configuration.

Passing release_on_start=True to a singleton task makes the task release the lock when the job starts running, rather than when it has finished.

Note: This is only available in celery versions 5.2 and above since it uses the before_start-method on the celery Task object which was introduced in version 5.2.

Example

@celery_app.task(base=Singleton, release_on_start=True)
def calculate_monthly_total(user_id):
    "Throttled update of `monthly_total` that ensures last user input is always accounted for"
    user = User.objects.get(id=user_id)
    monthly_total = [p.total for p in user.purchases.filter(month=datetime.utcnow().month, user=user)]
    user.update(last_modified=datetime.utcnow(), monthly_total=monthly_total)
    time.sleep(3)

# User triggers `calculate_monthly_total()` through various actions
task1 = calculate_monthly_total.delay(user_id=123)
task2 = calculate_monthly_total.delay(user_id=123) # throttled via singleton
time.sleep(1)
task3 = calculate_monthly_total.delay(user_id=123) # not throttled since the previous task has started
assert task1 == task2
assert task1 != task3

Passing `release_on_start=True` to a singleton task makes the task
release the lock when the job starts running, rather than when it has
finished.

Note: This is only available in celery versions 5.2 and above since it
uses the `before_start`-method on the celery Task object which was
introduced in version 5.2.
@tony
Copy link
Contributor

tony commented Oct 2, 2022

Thank you for looking at #44!

@steinitzu Could you also look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants