Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't unlock the task if lock_expiry is still valid #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aguedob
Copy link

@aguedob aguedob commented Oct 21, 2022

Hi!

In my use case I need the task result to be cached until the lock time expires, in order to avoid new tasks with the same input data.
Does it make sense to you keeping the lock even if the task has finished?

@steinitzu
Copy link
Owner

I would rather add a new parameter for this so it's not such a dramatic change in behaviour. E.g. unlock_when_finished (default True)

@steinitzu
Copy link
Owner

Possibly even separate params: unlock_on_success / unlock_on_failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants