Add SEP0010 transaction challenge builder. #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@morleyzhi I need to do a couple of cleanups and then it should be good - why did we disable namespaces in TypeScript? |
abuiles
commented
Jul 19, 2019
abuiles
force-pushed
the
abuiles/sep-10-challenge
branch
2 times, most recently
from
c13c0c1
to
82d7d28
Compare
|
@abuiles Because of Babel not supporting it there was a lot FUD of namespaces being "deprecated" or not "official", although Typescript team never said so. And then support came to Babel 20 days ago (babel/babel#9785). Unfortunately the whole FUD got so far as a linter rule. I'm all for using namespaces. |
morleyzhi
reviewed
Jul 19, 2019
abuiles
added a commit
to abuiles/product-conventions
that referenced
this pull request
Jul 22, 2019
This is turned on by `tslint:recommended`, but now that it is supported by babel we can use it safely. See @Akuukis comment here stellar/js-stellar-sdk#375 (comment).
morleyzhi
pushed a commit
to stellar/product-conventions
that referenced
this pull request
Jul 22, 2019
This is turned on by `tslint:recommended`, but now that it is supported by babel we can use it safely. See @Akuukis comment here stellar/js-stellar-sdk#375 (comment).
abuiles
changed the title
abuiles
force-pushed
the
abuiles/sep-10-challenge
branch
from
6d23b2e
to
36536b9
Compare
This was referenced Jul 22, 2019
abuiles
force-pushed
the
abuiles/sep-10-challenge
branch
from
36536b9
to
8a67e79
Compare
abuiles
changed the title
bartekn
reviewed
Jul 23, 2019
src/utils.ts
Outdated
| @@ -0,0 +1,66 @@ | |||
| import { randomBytes } from "crypto"; | |||
There was a problem hiding this comment.
I think we removed dependency on crypto package in stellar/js-stellar-base#169. You should probably use randombytes.
There was a problem hiding this comment.
@bartekn thanks for the heads up, fixed!
bartekn
approved these changes
Jul 23, 2019
This was referenced Aug 2, 2019
This was referenced Aug 2, 2019
lhtdeepaktomar
pushed a commit
to lhtdeepaktomar/js-stellar-sdk
that referenced
this pull request
Jun 11, 2021
* Allow account create operation with zero balance. * Update error message for invalid startingBalance in createAccountOp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add utils helper to build a SEP0010 valid challenge.
Sample output
Fixes #370
Example