Fix/tx build UI: Fix the break UI change on the transaction builder page #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
##Issue
#710
Description
Fix the break UI change on the transaction builder page. When filling in the inputs error title or success title changes conditionally breaking the transaction builder page and the user was unable to process further their transaction through UI. I was trying to execute changeTrust operation specifically where I found that bug.
Changes Made
In TxBuilderResult.js, wrapped the successTitle and errorTitle headings in the parent div, these lines were causing an error when the success heading or error heading appears conditionally.
Checklist
Screenshots (if applicable)