Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sign tx] add signing with secrets and ValidationResponseCard #839

Merged
merged 7 commits into from
May 28, 2024
Merged

[sign tx] add signing with secrets and ValidationResponseCard #839

merged 7 commits into from
May 28, 2024

Conversation

jeesunikim
Copy link
Contributor

@jeesunikim jeesunikim commented Apr 29, 2024 •
edited

Sign Transaction

  • Sign Transaction's Import and Overview view
  • Signing with secret keys enabled
  • We're not saving secret keys in store

note: waiting on design for the validation response's error state

@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr839.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr839.previews.kube001.services.stellar-ops.com/

@jeesunikim jeesunikim changed the title [sign tx] visuals [sign tx] add signing with secrets and ValidationResponseCard May 7, 2024
@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr839.previews.kube001.services.stellar-ops.com/

1 similar comment
@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr839.previews.kube001.services.stellar-ops.com/

@jeesunikim jeesunikim marked this pull request as ready for review May 8, 2024 17:55
@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr839.previews.kube001.services.stellar-ops.com/

@jeesunikim jeesunikim requested a review from quietbits May 8, 2024 17:59
quietbits
quietbits reviewed May 8, 2024
View reviewed changes
src/helpers/transactionSigner.ts Outdated Show resolved Hide resolved
src/styles/globals.scss Outdated Show resolved Hide resolved
src/app/(sidebar)/transaction/sign/components/Import.tsx Outdated Show resolved Hide resolved
src/app/(sidebar)/transaction/sign/components/Import.tsx Outdated Show resolved Hide resolved
src/app/(sidebar)/transaction/sign/components/Overview.tsx Outdated Show resolved Hide resolved
src/app/(sidebar)/transaction/sign/components/Overview.tsx Outdated Show resolved Hide resolved
src/app/(sidebar)/transaction/sign/components/Overview.tsx Show resolved Hide resolved
src/app/(sidebar)/transaction/sign/components/Overview.tsx Outdated Show resolved Hide resolved
src/app/(sidebar)/transaction/sign/components/Import.tsx Show resolved Hide resolved
@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr839.previews.kube001.services.stellar-ops.com/

@jeesunikim jeesunikim requested a review from quietbits May 9, 2024 19:08
@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr839.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr839.previews.kube001.services.stellar-ops.com/

@jeesunikim jeesunikim merged commit 0c4d480 into laboratory-v2 May 28, 2024
3 checks passed
@jeesunikim jeesunikim linked an issue May 28, 2024 that may be closed by this pull request
[Sign Transaction] Transaction Overview - Sign #815
Open
@jeesunikim jeesunikim deleted the signtx-sign branch May 28, 2024 18:02
@jeesunikim jeesunikim mentioned this pull request May 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quietbits quietbits quietbits approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Sign Transaction] Transaction Overview - Sign
3 participants
@jeesunikim @stellar-jenkins @quietbits