Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build Transaction] More operations pt. 4 #847

Merged
merged 16 commits into from
May 28, 2024
Merged

[Build Transaction] More operations pt. 4 #847

merged 16 commits into from
May 28, 2024

Conversation

quietbits
Copy link
Contributor

Added operations:

  • Clawback
  • Clawback Claimable Balance
  • Path Payment Strict Send
  • Path Payment Strict Receive

@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr847.previews.kube001.services.stellar-ops.com/

@quietbits quietbits requested a review from jeesunikim May 17, 2024 18:27
@jeesunikim
Copy link
Contributor

jeesunikim commented May 20, 2024 •
edited

Screenshot 2024-05-20 at 4 51 41 PM

what does this copy icon supposed to copy? it's currently copying the destination asset's issuer account ID. Is that expected?

Oh I see it copies the operation method!

Base automatically changed from v2-txn-ops-3 to laboratory-v2 May 28, 2024 13:01
@quietbits
Copy link
Contributor Author

Screenshot 2024-05-20 at 4 51 41 PM what does this copy icon supposed to copy? it's currently copying the destination asset's `issuer account ID`. Is that expected?

Oh I see it copies the operation method!

Yes, it duplicates the operation.

@quietbits quietbits requested a review from jeesunikim May 28, 2024 13:10
@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr847.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr847.previews.kube001.services.stellar-ops.com/

@quietbits quietbits merged commit 2246f9e into laboratory-v2 May 28, 2024
3 checks passed
@quietbits quietbits deleted the v2-txn-ops-4 branch May 28, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeesunikim jeesunikim jeesunikim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@quietbits @stellar-jenkins @jeesunikim