Deprecate admin guide #4312
Merged
Deprecate admin guide #4312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please rebase and resolve the conflicts? |
ElliotFriend
added a commit
to stellar/stellar-docs
that referenced
this pull request
May 28, 2024
stellar/stellar-core@075df81 included some changes to the soon- to-be-deprecated `admin.md` file within the codebase. This commit includes the changes from that commit, and adds those new details to `monitoring.mdx` in the core-node admin guide. Refs: stellar/stellar-core#4312
ElliotFriend
force-pushed
the
deprecate-admin-guide
branch
from
155ed50
to
ab94477
Compare
|
@dmkozh Thanks for reminder!
I also took the relevant changes from 075df81 (the commit that caused the conflicts), and put them into a PR for the docs site: stellar/stellar-docs#590. Let me know if there's anything else this PR needs. Thanks! |
ElliotFriend
force-pushed
the
deprecate-admin-guide
branch
from
9314053
to
1644ffa
Compare
ElliotFriend
added a commit
to stellar/stellar-docs
that referenced
this pull request
May 28, 2024
stellar/stellar-core@075df81 included some changes to the soon- to-be-deprecated `admin.md` file within the codebase. This commit includes the changes from that commit, and adds those new details to `monitoring.mdx` in the core-node admin guide. Refs: stellar/stellar-core#4312
sisuresh
approved these changes
May 28, 2024
|
r+ 1644ffa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves stellar/stellar-docs#341
This PR adds a deprecation notice to the
admin.mdandsoroban-settings.mddocuments, pointing readers/users/contributors to use the Admin Guide in the Stellar Docs site: https://developers.stellar.org/network/core-node/admin-guideChecklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)