Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore): update dependencies #91

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

christian-bromann
Copy link
Member

Starting a Stencil project using the "app" route currently fails due to:

Screenshot 2023-09-25 at 9 24 26 AM

It turns out that this starter project uses an outdated @stencil/core package and stops compiling correctly at this point given that transient Babel dependency versions use * and expect a TypeScript version higher than v2.

This patch updates some of the dependencies.

Status: work in progress

Running e2e tests still fails due to:

 RUNS  src/components/app-root/app-root.e2e.ts
/Users/christian.bromann/Sites/Ionic/projects/stencil-app-starter/node_modules/@stencil/core/testing/index.js:4525
  global.__CLOSE_OPEN_PAGES__ && await global.__CLOSE_OPEN_PAGES__(), testing.stopAutoApplyChanges();
                                                                              ^

TypeError: Caught error after test environment was torn down

testing.stopAutoApplyChanges is not a function
    at Object.<anonymous> (/Users/christian.bromann/Sites/Ionic/projects/stencil-app-starter/node_modules/@stencil/core/testing/index.js:4525:79)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Looking into fixing this as well.

@beenotung
Copy link

I just updated another stencil starter template recently without issue, maybe you can try again with the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants