chore(ESLint): Make strict-boolean-expressions more flexible. Close #4

stencila · May 27, 2020 · 079707f · 079707f
1 parent c7d59f2
commit 079707f
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 13 deletions.
diff --git a/packages/eslint-config/eslint-config-stencil.js b/packages/eslint-config/eslint-config-stencil.js
@@ -3,9 +3,18 @@ const defaultConfig = require('./eslint-config')
 module.exports = {
   ...defaultConfig,
   extends: ['plugin:@stencil/recommended'],
+  rules: {
+    '@typescript-eslint/no-unused-vars': 0,
+    '@typescript-eslint/no-unused-vars-experimental': [
+      'error',
+      {
+        ignoredNamesRegex: '^_|^component(Will|Did)(Un)?[Ll]oad'
+      }
+    ]
+  },
   parserOptions: {
     ...defaultConfig.parserOptions,
     project: './tsconfig.json',
-    jsx: true
-  }
+    jsx: true,
+  },
 }
diff --git a/packages/eslint-config/eslint-config.js b/packages/eslint-config/eslint-config.js
@@ -6,7 +6,7 @@ module.exports = {
     'plugin:@typescript-eslint/recommended-requiring-type-checking',
     'prettier',
     'prettier/@typescript-eslint',
-    'plugin:prettier/recommended'
+    'plugin:prettier/recommended',
   ],
   plugins: ['@typescript-eslint', 'prettier'],
   rules: {
@@ -15,15 +15,15 @@ module.exports = {
       {
         functions: false,
         // Because sometimes we define functions using const func = ...
-        variables: false
-      }
+        variables: false,
+      },
     ],
     '@typescript-eslint/explicit-function-return-type': [
       'warn',
       {
         allowExpressions: true,
-        allowHigherOrderFunctions: true
-      }
+        allowHigherOrderFunctions: true,
+      },
     ],
     '@typescript-eslint/ban-ts-ignore': 'warn',
     '@typescript-eslint/await-thenable': 'warn',
@@ -33,7 +33,10 @@ module.exports = {
     '@typescript-eslint/prefer-optional-chain': 'error',
     '@typescript-eslint/strict-boolean-expressions': [
       'error',
-      { allowNullable: true }
+      {
+        allowString: false,
+        allowNullableBoolean: true,
+      },
     ],
     '@typescript-eslint/no-unused-vars': [
       'warn',
@@ -42,13 +45,12 @@ module.exports = {
         //    const { content, ...rest } = node
         //    return rest
         ignoreRestSiblings: true,
-        varsIgnorePattern: 'h' // This is for JSX support in StencilJS
-      }
-    ]
+      },
+    ],
   },
   parserOptions: {
     project: './tsconfig.json',
     ecmaVersion: 2018,
-    sourceType: 'module'
-  }
+    sourceType: 'module',
+  },
 }