Add log level color keys and handle default #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adding a default white color when the key is not recognize. Without the default an error is printed instead of the log entry.
hogklint
requested review from
superbrothers,
floryut,
rkmathi and
tksm
as code owners
tksm
reviewed
May 4, 2023
Co-authored-by: Takashi Kusumi <tkusumi@zlab.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to solve issue #263 by handling two more common log-level keys as well as handling the fallback case so that an error is never printed. The two new keys are used in Python's logging facilities.
I didn't find a way to add custom log-level keys as a user, but I think this works well. It would be very appreciated if it didn't cause an error at least.
Test by using stern to print logs from a Python application that emits "warning" and "critical" logs. Preferably also test with an unknown key