New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies and tools #273
Conversation
b3e2b16
to
39c8330
Compare
@@ -54,7 +54,7 @@ verify-readme: | |||
|
|||
.PHONY: validate-krew-manifest | |||
validate-krew-manifest: $(VALIDATE_KREW_MAIFEST) | |||
$(VALIDATE_KREW_MAIFEST) -manifest dist/stern.yaml -skip-install | |||
$(VALIDATE_KREW_MAIFEST) -manifest dist/krew/stern.yaml -skip-install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 The manifest path was changed in goreleaser/goreleaser@76ce66c.
@@ -521,7 +521,7 @@ func TestOptionsSternConfig(t *testing.T) { | |||
c.AllNamespaces = true | |||
c.LabelSelector = labelSelector | |||
c.FieldSelector = fieldSelector | |||
c.TailLines = pointer.Int64(10) | |||
c.TailLines = ptr.To[int64](10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 The pointer
package was deprecated in kubernetes/utils@dc1a5d8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tksm Thank you 👍
This PR updates the dependencies for the release of Kubernetes v1.28.0. I checked the latest versions of the tool on the following URLs.