Skip to content

stevemao/awesome-pull-requests

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

5 Commits
 
 
 
 

Repository files navigation

Knowing the thinking behind the code, discussing with other developers, and working together on great projects. Awesome

chalk/chalk#25

Adds support for nested chalk expressions, by @jbnicolai

Landed! Excellent work sir. This is the best PR I've gotten in a long while. -- @sindresorhus


chalk/chalk#27

Performance optimizations, by @jbnicolai

Amazing. This is perfect. Landed. Thanks so much for looking into this 💃 -- @sindresorhus


chalk/chalk#33

fix caching of styles, by @seanmonstar

Fantastic pull-request! 🌟 -- @jbnicolai

The best use-case of Object.prototype.__proto__. This is usually considered bad. However, due to the algorithm it's used in such particular use-case, this implementation is faster than other solutions. Check out the excellent explanation!


reduxjs/redux#1930

Structuring reducers page, by @markerikson

This looks great, amazing effort! -- ellbee


reduxjs/redux#1887

add examples with Flowtype support + libdefs for redux and react-redux, by @gcanti

OK, we've got @MarcoPolo, @aaronjensen, and @alexeygolev all saying this looks good. So, it's on you 3 if the community gets out their pitchforks 🔥 😈 -- @timdorr


reduxjs/redux#1632

add observable proposal interop to store, by @blesh

Looking great. Will cut a release tomorrow. -- @gaearon


facebook/react#7549

Show React events in the timeline when ReactPerf is active, by @gaearon


facebook/react#5753

Don't wrap text in elements, by @mwiencek

This looks great. Thank you so much! -- @spicyj


so-fancy/diff-so-fancy#90

Clean up the headers to indicate a file was added/removed/modified, by @scottchiefbaker

lookin sharp. merging… -- @paulirish


nodejs/node#8317

deps: update V8 to 5.4, by @targos

Landed in d2eb7ce...91b4094 -- @targos


juliangruber/balanced-match#7

Optimisations, by @neytema

But yes, impressive as heck! -- @isaacs


angular/angular.js#10732

Make modules Browserify compatible, by @bclinkinbeard

This PR was not merged but this leads to great discussion how to better support both newer and older module systems. In the early days angular and it's submodules were not common.js compatible. Angular, instead, had it's own module system with dependency injection. @bendrucker took the initiative and manually update all modules to be requireable. Also see this blog post.


nodejs/node#6792

Add v8_inspector support, by @ofrobots


facebook/react#6534

consistent owner for stateless component, by @yiminghe

I guess this fix is correct. The logic here is very confusing though -- @spicyj


facebook/react#7232

Fix unmounting performance regression in V8, by @gaearon

dogscience -- @spicyj


eslint/eslint#6215

🦄 Utilize glob ignore option for massive perf win 🦄, by @samccone


vuejs/vue#3509

Add typescript definition, by @kaorun343

Thanks for the hard work! -- @yyx990803


lerna/lerna#237

Update bootstrap command, by @rygine

Thanks for your patience and work on this one! -- @hzoo


babel/babel#3561

add options for different parser/generator, by @hzoo


jquery/jquery#1103

Support Node-like module loaders, by @isaacs

Great! -- @rwaldron


facebook/react#7616

Generate SimpleEventPlugin data structures at runtime, by @vjeux

(Accepted for the historical record.) -- @spicyj


microsoft/TypeScript#11267

Add jsxFactory compiler option, by @bradleyayers


rollup/rollup#774

Avoid lazy parsing by adding parens around factory, by @bmaurer


License

CC0

To the extent possible under law, Steve Mao has waived all copyright and related or neighboring rights to this work.

Releases

No releases published

Packages

No packages published