Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add type "button" on components buttons to avoid send form #112

Merged
merged 9 commits into from Aug 26, 2023

Conversation

SmookeyDev
Copy link
Contributor

@SmookeyDev SmookeyDev commented Aug 12, 2023

When using the editor within a form, clicking any option of components causes submit on form. Specifying the "button" type prevents this issue.

On case of link-selector, i needed to make a simple refactory, because she input is inside an form.

@vercel
Copy link

vercel bot commented Aug 12, 2023

@SmookeyDev is attempting to deploy a commit to the Elegance Team on Vercel.

A member of the Team first needs to authorize it.

@SmookeyDev SmookeyDev changed the title fix: add type "button" on bubble-menu buttons to avoid send form fix: add type "button" on components buttons to avoid send form Aug 12, 2023
@steven-tey
Copy link
Owner

Will keep the link-selector inside a form for now, but thank you for the PR!

@steven-tey steven-tey merged commit 44e7775 into steven-tey:main Aug 26, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants