Response to comment with unit test code for JSONDivider #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thswlsqls
changed the title
|
It may be a new library with a json divider class |
|
Not a good fit for the project at this time. |
|
Thank you and appreciate your confirmation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, stleary.
I'm Eunbin , a korean software developer.
I'm writing you to response your comment from
#735
Thank you for your quick comment and advice.
It encourage me to try again the pull request in improved way.
I read again the documents you mentioned,
and fix previous pull request code as well as add unit test code.
If you don't mind me asking,
Can you examine whether it can helps other developers or not one more time?
Thank you and best regards,