Ensure java 6 compatable #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnjaylward
force-pushed
the
ensure_1-6_compat
branch
from
ac2120d
to
a2a8240
Compare
johnjaylward
force-pushed
the
ensure_1-6_compat
branch
from
40b9a29
to
ea842b4
Compare
|
@johnjaylward Looks good, thanks! |
stleary
added
Hacktoberfest
and removed
Approved - 3-day window
hacktoberfest-accepted
labels
stleary
approved these changes
Oct 25, 2023
|
you removed the approved label but didn't merge. Was that intentional? |
|
@johnjaylward My bad, it was still in the 3-day window. Going ahead and merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this code solve?
Adds back in the build/jar for java6 to help ensure binary source compatibility. This leaves the actual deployment to Maven Central as a Java 8 compatibility.
Sample build run: https://github.com/johnjaylward/JSON-java/actions/runs/6617867256
As part of the java6 build, I made sure to output the current version of the java compiler:
This PR also adds support for auto-uploading the JARs built during the "Deployment Workflow" to the GitHib release. See https://github.com/johnjaylward/JSON-java/releases/tag/20231023-SNAP-01 as an example of what the release would look like.
Does the code still compile with Java6?
Yes, that's what this PR is made to ensure.
Risks
To compile Java 1.6 on GitHub, it requires using the deprecated action "setup-java@v1".
v2and greater of the action do not support java6. It's unknown when GitHub will end support for this action completely. Once they do, builds will break and we will need to "cross compile" from a newer version of the JDK down to 1.6, which is not guaranteed to ensure full 1.6 compatibility.Changes to the API?
No
Will this require a new release?
No
Should the documentation be updated?
No
Does it break the unit tests?
No. However, no testing is done against JDK 6. Only compilation of
src/mainand packing is performed. The JDK-1.6 jar that is uploaded to the build artifacts is also not compatible with JDK 9+ as no module information is providedWas any code refactored in this commit?
No
Review status
APPROVED
Starting 3-day comment window