Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove-jsonparserconfig-ctor - just use withOverwriteDuplicateKey() #876

Merged
merged 1 commit into from Mar 9, 2024

Conversation

stleary
Copy link
Owner

@stleary stleary commented Mar 9, 2024

Description
Remove overloaded JSONParserConfiguration ctor. Use withOverwriteDuplicateKey() instead

Refactoring
None

Testing done
unit tests

@stleary
Copy link
Owner Author

stleary commented Mar 9, 2024

What problem does this code solve?
Removes an unneeded ctor from JSONParserConfiguration

Does the code still compile with Java6?
Yes

Risks
Low

Changes to the API?
Yes, but the ctor was added in a recent commit

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No, unit tests were updated

Was any code refactored in this commit?
No

Review status
APPROVED - by myself, for immediate release

@stleary stleary merged commit 48c092a into master Mar 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant