Implement flash read un/protection per PM0075 #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRealBluesun
changed the title
TheRealBluesun
force-pushed
the
flash_protection
branch
from
82609d4
to
00dbeb6
Compare
TheRealBluesun
commented
Dec 27, 2020
| while self.flash.sr.sr().read().bsy().bit_is_set() {} | ||
|
|
||
| // First we must erase the Option Bytes | ||
| self.erase_opt()?; |
There was a problem hiding this comment.
Taking a second look -- this needs to retain the USER byte value and others. Maybe we can get away without erasing them entirely? The documentation is a little ambiguous.
There was a problem hiding this comment.
Update on this:
Writing the RDP value will fail if we haven't erased the Option Bytes first. I've tried saving off the upper half-word and writing it with the new RDP value, but I can't get it to accept it. Will have to investigate more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
This PR exposes the Read protection feature offered by STMF1xx series MCUs. This feature is implemented as described in the PM0075 Programming manual Doc ID 17863 Rev 2.
Please do review the comments and formatting -- I'd love some feedback there.
Side note -- this was a very fun first contribution to the Rust embedded community; long overdue.