#54 Update webpack to version 4 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilmillasseau
changed the title
stoikerty
approved these changes
Apr 6, 2018
There was a problem hiding this comment.
Looks good! thanks for doing this. I will add a few more changes to this PR and get it merged.
We'll look at the vulnerabilities once more once there is progress. Unfortunately as of webpack 4.5.0 they still persist but there is no point in delaying this release any further.
|
#52 has been fixed as part of this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extract-text-webpack-plugin@4.0.0-beta.0to keep compatibility with webpack v4Initially, we were looking to get rid of the vulnerabilities but it turns out that webpack 4.0.1 still has all the vulnerabilities. So it's likely we'll have to wait for a bit before releasing v7.
Related: