-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACM-10914 upgrade to react router dom v5 compat #3457
base: main
Are you sure you want to change the base?
ACM-10914 upgrade to react router dom v5 compat #3457
Conversation
…-10914-Upgrade-to-react-router-dom-v5-compat-package Signed-off-by: John Swanke <jswanke@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jeswanke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: John Swanke <jswanke@redhat.com>
Signed-off-by: John Swanke <jswanke@redhat.com>
…-10914-Upgrade-to-react-router-dom-v5-compat Signed-off-by: John Swanke <jswanke@redhat.com>
/hold |
Signed-off-by: John Swanke <jswanke@redhat.com>
Quality Gate failedFailed conditions |
@jeswanke: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Is this being worked on ? CIM is also looking to upgrade to v5 compat but this work needs to merge first. I believe you need to upgrate |
@rawagner Yes, you are correct we need to bump |
https://docs.google.com/document/d/1ea1lsh6CekZjuPmpWH5c3NohlVnCBpnWzmXCZFLZrks/edit?usp=sharing
NOTE: AI plugin must be updated to compat--v6 doesn't support RouteComponentProps in component constructor
{/* <Route path="/edit/:namespace/:name" element={} /> */}
NOTE: LostChanges.tsx and LostChanges.test.tsx have been commented out/skipped