Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACM-10914 upgrade to react router dom v5 compat #3457

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

jeswanke
Copy link
Contributor

@jeswanke jeswanke commented Apr 29, 2024

  1. lots of files but most are simple changing of Link to v5-compat
  2. a guide to other changes:
    https://docs.google.com/document/d/1ea1lsh6CekZjuPmpWH5c3NohlVnCBpnWzmXCZFLZrks/edit?usp=sharing

NOTE: AI plugin must be updated to compat--v6 doesn't support RouteComponentProps in component constructor
{/* <Route path="/edit/:namespace/:name" element={} /> */}

NOTE: LostChanges.tsx and LostChanges.test.tsx have been commented out/skipped

Signed-off-by: John Swanke <jswanke@redhat.com>
Signed-off-by: John Swanke <jswanke@redhat.com>
Signed-off-by: John Swanke <jswanke@redhat.com>
Signed-off-by: John Swanke <jswanke@redhat.com>
…-10914-Upgrade-to-react-router-dom-v5-compat-package

Signed-off-by: John Swanke <jswanke@redhat.com>
Signed-off-by: John Swanke <jswanke@redhat.com>
Signed-off-by: John Swanke <jswanke@redhat.com>
Copy link

openshift-ci bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeswanke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: John Swanke <jswanke@redhat.com>
Signed-off-by: John Swanke <jswanke@redhat.com>
Signed-off-by: John Swanke <jswanke@redhat.com>
Signed-off-by: John Swanke <jswanke@redhat.com>
Signed-off-by: John Swanke <jswanke@redhat.com>
…-10914-Upgrade-to-react-router-dom-v5-compat

Signed-off-by: John Swanke <jswanke@redhat.com>
Signed-off-by: John Swanke <jswanke@redhat.com>
Signed-off-by: John Swanke <jswanke@redhat.com>
Signed-off-by: John Swanke <jswanke@redhat.com>
@KevinFCormier
Copy link
Contributor

/hold

Signed-off-by: John Swanke <jswanke@redhat.com>
@KevinFCormier KevinFCormier changed the title Acm 10914 upgrade to react router dom v5 compat ACM-10914 upgrade to react router dom v5 compat May 3, 2024
Signed-off-by: John Swanke <jswanke@redhat.com>
Copy link

sonarcloud bot commented May 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
69.7% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

Copy link

openshift-ci bot commented May 3, 2024

@jeswanke: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit-tests-sonarcloud 9962fe0 link true /test unit-tests-sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rawagner
Copy link
Contributor

Is this being worked on ? CIM is also looking to upgrade to v5 compat but this work needs to merge first.

I believe you need to upgrate @openshift-console/dynamic-plugin-sdk-webpack to 0.0.11 in order for the react-router-dom-v5-compat module federation to work correctly

@KevinFCormier
Copy link
Contributor

@rawagner Yes, you are correct we need to bump @openshift-console/dynamic-plugin-sdk-webpack to 0.0.11, however, at that level I am seeing discrepancies in behaviour between OCP 4.14 and 4.15. We may need to delay one release. I am finishing up some other work and hope to get back to this shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants