Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACM-11092] Handle update of missing kinds in endpoint controller. #1426

Merged
merged 1 commit into from
May 16, 2024

Conversation

thibaultmg
Copy link
Contributor

@thibaultmg thibaultmg commented May 3, 2024

The endpoint operator is only able de create certain type of resources and is unable to update them afterwards.
This also happens on all *KS clusters or non openshift, i.e. when we need to deploy the prometheus stack.
Keeping them under the control of the operator ensures a stable configuration and probably avoids some upgrade issues.

Adds update handling for kinds: Role, RoleBinding, ServiceAccount, DaemonSet, serviceMonitor

Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
64.5% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

Copy link

openshift-ci bot commented May 16, 2024

@thibaultmg: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonarcloud 98585dd link true /test sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@coleenquadros
Copy link
Contributor

lgtm

Copy link

openshift-ci bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coleenquadros, thibaultmg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [coleenquadros,thibaultmg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thibaultmg thibaultmg merged commit 27de3a2 into stolostron:main May 16, 2024
12 of 15 checks passed
@thibaultmg thibaultmg deleted the ACM_11092 branch May 16, 2024 11:25
coleenquadros pushed a commit to coleenquadros/multicluster-observability-operator that referenced this pull request May 23, 2024
Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants