Improve e2e logs #1435
Merged
Improve e2e logs #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
thibaultmg
force-pushed
the
improve_e2e_logs
branch
from
f5bc77b
to
8be4418
Compare
thibaultmg
force-pushed
the
improve_e2e_logs
branch
from
8be4418
to
8ec9980
Compare
thibaultmg
force-pushed
the
improve_e2e_logs
branch
from
5ba7557
to
9f35f1e
Compare
Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
thibaultmg
force-pushed
the
improve_e2e_logs
branch
from
7594281
to
cffd573
Compare
Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
|
/test test-e2e |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: philipgough, thibaultmg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I am waiting to make e2e pass and check the logging results before merging. Yesterday e2e did not work... |
Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
|
New changes are detected. LGTM label has been removed. |
|
coleenquadros
pushed a commit
to coleenquadros/multicluster-observability-operator
that referenced
this pull request
May 23, 2024
* change test ContainManagedClusterMetric Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * improve e2e test logging Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * add kube_debug file Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * remove unused functions Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * reduce log lines Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * log statefulsets and daemonsets Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * add copyright Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * fix pods list, add cm and secrets list Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> --------- Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
jacobbaungard
pushed a commit
to jacobbaungard/multicluster-observability-operator
that referenced
this pull request
May 30, 2024
* change test ContainManagedClusterMetric Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * improve e2e test logging Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * add kube_debug file Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * remove unused functions Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * reduce log lines Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * log statefulsets and daemonsets Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * add copyright Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * fix pods list, add cm and secrets list Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> --------- Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
jacobbaungard
pushed a commit
to jacobbaungard/multicluster-observability-operator
that referenced
this pull request
May 30, 2024
* change test ContainManagedClusterMetric Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * improve e2e test logging Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * add kube_debug file Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * remove unused functions Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * reduce log lines Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * log statefulsets and daemonsets Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * add copyright Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * fix pods list, add cm and secrets list Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> --------- Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
jacobbaungard
pushed a commit
to jacobbaungard/multicluster-observability-operator
that referenced
this pull request
May 30, 2024
* change test ContainManagedClusterMetric Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * improve e2e test logging Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * add kube_debug file Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * remove unused functions Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * reduce log lines Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * log statefulsets and daemonsets Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * add copyright Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * fix pods list, add cm and secrets list Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> --------- Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
jacobbaungard
pushed a commit
to jacobbaungard/multicluster-observability-operator
that referenced
this pull request
May 30, 2024
* change test ContainManagedClusterMetric Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * improve e2e test logging Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * add kube_debug file Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * remove unused functions Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * reduce log lines Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * log statefulsets and daemonsets Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * add copyright Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * fix pods list, add cm and secrets list Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> --------- Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
jacobbaungard
added a commit
that referenced
this pull request
May 30, 2024
* Tests: Improve getting snapshots from Quay - Get the version from `COMPONENT_VERSION` instead of hardcoding it in two places - Improve the regex so it explicitly sets the z version number to 1-2 digits avoiding mistakes in matches (i.e 2.10.* could match 2.2.10) - Don't differentiate between how we get snapshot between release and other branches (just always get the latest snapshot we can find for the release we want) - Since Quay returns multiple pages of tags, we might get unlikly and not get any tags for the release we actually want. Therefore we add quay side filtering as well to ensure we only get snapshots for a specific release, and also ensure we get the most number of results we can (100 is the max) Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com> * Tests: Always use CI generated images Prior to this commit, we would try to determine which components have changed, and only if a component changed, we would use the CI generated image. Otherwise we would try to get the latest snapshot from Quay. However, the way we get the latest snapshot from Quay is not guranteed to give us the very latest version (it will give us probably a resonably recent one), so to make sure we always test the latest change, just use all the images built using CI. Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com> * E2e tests (#1400) * fix e2e tests Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * [ACM-10511] Update hub collector with the whole obs addon spec (#1386) * Update hub collector with the whole obs addon spec Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Fetch OA spec from MCO on collector if in the hub Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Refactor bool far assignment Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Remove unnecessary global variable Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> --------- Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * [ACM-10511] Improve robustness when listing MCO CRs from the collector (#1390) * Improve robustness when listing MCO CRs from the collector Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Fix assignment Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Remove unused vars Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> --------- Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * [ACM-6112] Fix invalid uwl service monitors for hypershift hosted etcd and api-server (#1352) * Fix hypershift servicemon Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * fixes Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * add copyright Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * avoid reconcile failure if hypershift smon fail Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * add cluster labels relabelling Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * add missing copyright Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * fix empty newline Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * remove top level logs Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * clean test CRDs Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * fix error message Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * clean logs in openshift pkg Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * fix merge Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> --------- Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * fix e2e Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * typo Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * typo Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * allow prometheus to be installed in kind Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * annotate version Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * ensure controller ref is not set for hub prometheus resources in kind Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * refactor for hub Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * refactor for hub Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * refactor for hub Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * refactor Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * chnage resource limits Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * endpointmetrics: Do not add genereted resources as volumes on ocp3 clusters (#1384) Signed-off-by: Philip Gough <philip.p.gough@gmail.com> * [ACM-10511] Update hub collector with the whole obs addon spec (#1386) * Update hub collector with the whole obs addon spec Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Fetch OA spec from MCO on collector if in the hub Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Refactor bool far assignment Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Remove unnecessary global variable Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> --------- Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * [ACM-10511] Improve robustness when listing MCO CRs from the collector (#1390) * Improve robustness when listing MCO CRs from the collector Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Fix assignment Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Remove unused vars Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> --------- Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * [ACM-6112] Fix invalid uwl service monitors for hypershift hosted etcd and api-server (#1352) * Fix hypershift servicemon Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * fixes Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * add copyright Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * avoid reconcile failure if hypershift smon fail Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * add cluster labels relabelling Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * add missing copyright Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * fix empty newline Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * remove top level logs Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * clean test CRDs Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * fix error message Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * clean logs in openshift pkg Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * fix merge Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> --------- Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * typo Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * typo Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * allow prometheus to be installed in kind Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * refactor for hub Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * refactor Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * remove duplicates Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * remove duplicates Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * refactor Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * ensure hubclient scheme is correct Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * lint Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * update prometheus role Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * resource limit Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * lint Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * lint Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * lint Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * lint Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * resource Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * Add resource for init-config-reloader in prom Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * test build Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * trigger build Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * chnage namespace in rolebinding Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * correct namespace in role and rolebindings Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * revert for e2e Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * refactor Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * test SA reconcile Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * logs Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * logs Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * logs Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * logs Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * logs Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * remove file Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * comments Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> * remove logs Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> --------- Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> Signed-off-by: Philip Gough <philip.p.gough@gmail.com> Co-authored-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> Co-authored-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> Co-authored-by: Philip Gough <philip.p.gough@gmail.com> * Tests: Don't check remote_write_requests on spokes (#1433) * Tests: Don't check remote_write_requests on spokes Previously the test "Should have acm_remote_write_requests_total metrics with correct labels/value" looked for the metric for both the hub cluster and any spokes. However, the spokes isn't supposed to expose this metric, hence the test would always fail if any managed clusters were added to the test setup. Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com> * Examples: remove `cleanupInterval` This configuration option no longer exists, so removing from example files used in tests. Avoids the following warnings: ``` W0513 07:54:14.364463 11051 warnings.go:70] unknown field "spec.advanced.retentionConfig.cleanupInterval" ``` Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com> --------- Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com> * Improve e2e logs (#1435) * change test ContainManagedClusterMetric Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * improve e2e test logging Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * add kube_debug file Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * remove unused functions Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * reduce log lines Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * log statefulsets and daemonsets Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * add copyright Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * fix pods list, add cm and secrets list Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> --------- Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> --------- Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com> Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> Signed-off-by: Philip Gough <philip.p.gough@gmail.com> Co-authored-by: Coleen Iona Quadros <coleen.quadros27@gmail.com> Co-authored-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> Co-authored-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> Co-authored-by: Philip Gough <philip.p.gough@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.