Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests to github workflows #1436

Merged
merged 2 commits into from
May 22, 2024
Merged

Add integration tests to github workflows #1436

merged 2 commits into from
May 22, 2024

Conversation

thibaultmg
Copy link
Contributor

Adds envtest based integration tests to github workflows.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 15, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thibaultmg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thibaultmg thibaultmg force-pushed the add_integration_test_ci branch 2 times, most recently from ca7f070 to bd2fdef Compare May 15, 2024 12:08
@thibaultmg thibaultmg marked this pull request as ready for review May 15, 2024 12:12
saswatamcode
saswatamcode reviewed May 15, 2024
View reviewed changes
.github/workflows/integration_tests.yaml
cache-dependency-path: "**/*.sum"

- name: Install deps
run: make deps
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth adding short go build step before? So we don't run tests if things don't properly build?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, done!

@thibaultmg
add github workflow
7505f41 
Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
@thibaultmg
add build step
22d62ac 
Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@thibaultmg thibaultmg merged commit 491589e into stolostron:main May 22, 2024
14 of 15 checks passed
@thibaultmg thibaultmg deleted the add_integration_test_ci branch May 22, 2024 14:40
coleenquadros pushed a commit to coleenquadros/multicluster-observability-operator that referenced this pull request May 23, 2024
@thibaultmg @coleenquadros
Add integration tests to github workflows (stolostron#1436)
29ed654 
* add github workflow

Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>

* add build step

Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>

---------

Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saswatamcode saswatamcode saswatamcode left review comments

Assignees
No one assigned
Labels
approved dco-signoff: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thibaultmg @saswatamcode