Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the addon-framework to 0.2.0 #279

Closed
wants to merge 1 commit into from

Conversation

skitt
Copy link
Member

@skitt skitt commented Feb 10, 2022

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from skitt after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@skitt skitt force-pushed the addon-framework-0.2.0 branch 3 times, most recently from de7a394 to 391cb8c Compare February 10, 2022 17:28
@skitt skitt linked an issue Feb 10, 2022 that may be closed by this pull request
@skitt
Copy link
Member Author

skitt commented Feb 10, 2022

/test unit

@skitt
Copy link
Member Author

skitt commented Feb 10, 2022

/test integration

Signed-off-by: Stephen Kitt <skitt@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 7, 2022

@skitt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 6b0dda6 link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dfarrell07
Copy link
Contributor

+ bash ./vendor/k8s.io/code-generator/generate-groups.sh client,lister,informer github.com/stolostron/submariner-addon/pkg/client/submarinerconfig github.com/stolostron/submariner-addon/pkg/apis submarinerconfig:v1alpha1 --go-header-file hack/../hack/../hack/boilerplate.txt --verify-only
Generating clientset for submarinerconfig:v1alpha1 at github.com/stolostron/submariner-addon/pkg/client/submarinerconfig/clientset
F0407 09:09:21.815382   21[97](https://prow.ci.openshift.org/spyglass/lens/buildlog/iframe?req=%7B%22artifacts%22%3A%5B%22build-log.txt%22%5D%2C%22index%22%3A1%2C%22src%22%3A%22gs%2Forigin-ci-test%2Fpr-logs%2Fpull%2Fstolostron_submariner-addon%2F279%2Fpull-ci-stolostron-submariner-addon-main-verify%2F1511991741404680192%22%7D&topURL=https%3A//prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/stolostron_submariner-addon/279/pull-ci-stolostron-submariner-addon-main-verify/1511991741404680192&lensIndex=1#build-log.txt:97)5 main.go:62] Error: Failed executing generator: some packages had errors:
errors in package "github.com/stolostron/submariner-addon/pkg/client/submarinerconfig/clientset/versioned":
output for "versioned/clientset.go" differs; first existing/expected diff: 
  "\n\tsubmarineraddonv1alpha1 \"github.com/stolostron/submariner-addon/pkg/client/submarinerconfig/client"
  "\t\"net/http\"\n\n\tsubmarineraddonv1alpha1 \"github.com/stolostron/submariner-addon/pkg/client/submarinerc"
errors in package "github.com/stolostron/submariner-addon/pkg/client/submarinerconfig/clientset/versioned/typed/submarinerconfig/v1alpha1":
output for "v1alpha1/submarinerconfig_client.go" differs; first existing/expected diff: 
  "v1alpha1 \"github.com/stolostron/submariner-addon/pkg/apis/submarinerconfig/v1alpha1\"\n\t\"github.com/st"
  "\"net/http\"\n\n\tv1alpha1 \"github.com/stolostron/submariner-addon/pkg/apis/submarinerconfig/v1alpha1\"\n\t\""
errors in package "github.com/stolostron/submariner-addon/pkg/client/submarinerconfig/clientset/versioned/typed/submarinerconfig/v1alpha1/fake":
output for "fake/fake_submarinerconfig.go" differs; first existing/expected diff: 
  "(submarinerconfigsResource, c.ns, name), &v1alpha1.SubmarinerConfig{})\n\n\treturn err\n}\n\n// DeleteColl"
  "WithOptions(submarinerconfigsResource, c.ns, name, opts), &v1alpha1.SubmarinerConfig{})\n\n\treturn err"

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/stolostron_submariner-addon/279/pull-ci-stolostron-submariner-addon-main-verify/1511991741404680192

@github-actions
Copy link

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 2, 2022

@skitt: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tpantelis
Copy link
Collaborator

Superseded by #389.

@tpantelis tpantelis closed this Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to controller-runtime 0.11.0 or later
3 participants