Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SL-84 and more improvements #5

Merged
merged 5 commits into from Oct 24, 2018
Merged

SL-84 and more improvements #5

merged 5 commits into from Oct 24, 2018

Conversation

chris-miaskowski
Copy link
Contributor

@chris-miaskowski chris-miaskowski commented Oct 24, 2018

Summary

My changes rename *.ts to *.d.ts (explained why below). Karol's change improves the interface.

This is related to the build process and a typescript compilation error that is throw under the following conditions:

@billiegoose
Copy link
Member

LGTM... IIRC ".d.ts" are "ambient declaration files". I don't know why it works that way, but I guess the idea is packages would normally export a CommonJS ".js" as main and then a "types-only" file as types.

@marbemac
Copy link
Contributor

Looks good to me for now - I'm writing up a plan to finally organize our repos a bit better (hopefully :)).

@marbemac marbemac merged commit ba7b12e into master Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants