Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Upgrade to Storybook 8 #227

Closed
wants to merge 5 commits into from
Closed

WIP: Upgrade to Storybook 8 #227

wants to merge 5 commits into from

Conversation

ShaunEvening
Copy link
Contributor

@ShaunEvening ShaunEvening commented Jan 16, 2024

What changed

  • Update to node 18
  • Update Storybook to v8
  • Update React to v18
  • Add @storybook/addon-webpack5-compiler-swc for compiler
  • Remove mdx-gfm addon
  • Replace use of @storybook/addons with @storybook/manager-api and @storybook/preview-api

Copy link

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@storybook/addon-actions 7.0.24...8.0.0-alpha.10 eval, environment +5/-46 1.1 MB shilman
storybook 7.0.24...8.0.0-alpha.10 None +249/-262 274 MB shilman
@types/webpack-env 1.18.1...1.18.4 None +0/-0 16.7 kB types
@babel/preset-react 7.22.5...7.23.3 None +30/-33 10 MB nicolo-ribaudo
@storybook/addon-links 7.0.24...8.0.0-alpha.10 eval, environment +2/-41 932 kB shilman
@babel/preset-typescript 7.22.5...7.23.3 None +33/-36 10.5 MB nicolo-ribaudo
@storybook/components 7.0.24...8.0.0-alpha.10 None +41/-58 16.5 MB shilman
@storybook/components 7.0.24...7.6.8 None +90/-0 22.9 MB shilman
@storybook/manager-api 7.0.24...8.0.0-alpha.10 environment +33/-38 10.8 MB shilman
@types/react-dom 17.0.20...18.2.18 None +4/-4 1.66 MB types
@storybook/theming 7.0.24...8.0.0-alpha.10 None +4/-8 5.66 MB shilman
@storybook/react 7.0.24...8.0.0-alpha.10 shell +89/-90 228 MB shilman
@storybook/theming 7.0.24...7.6.8 environment +4/-0 5.66 MB shilman
@storybook/core-events 7.0.24...8.0.0-alpha.10 None +0/-0 84.6 kB shilman
@babel/preset-env 7.22.5...7.23.8 None +98/-102 13.4 MB nicolo-ribaudo
@babel/core 7.22.5...7.23.7 None +25/-28 9.92 MB nicolo-ribaudo
@storybook/preview-api 7.0.24...8.0.0-alpha.10 None +28/-33 5.13 MB shilman
@types/react 17.0.62...18.2.48 None +3/-3 1.63 MB types
@storybook/blocks 7.0.24...7.6.8 shell +153/-97 244 MB shilman
react 17.0.2...18.2.0 None +0/-0 316 kB gnoff
@figspec/components 1.0.1...1.0.3 None +6/-6 3.09 MB pockawoooh
react-dom 17.0.2...18.2.0 None +4/-4 5.32 MB gnoff
@storybook/react-webpack5 7.0.24...8.0.0-alpha.10 shell +165/-184 245 MB shilman
@storybook/addon-storysource 7.0.24...8.0.0-alpha.10 None +30/-67 15.1 MB shilman
@storybook/addon-docs 7.0.24...8.0.0-alpha.10 shell +141/-302 250 MB shilman
@auto-it/released 11.0.1...11.0.4 None +18/-17 12.2 MB alisowski
@storybook/addon-docs 7.0.24...7.6.8 shell +201/-0 251 MB shilman
auto 11.0.1...11.0.4 None +24/-23 12.4 MB alisowski

🚮 Removed packages: @storybook/addon-mdx-gfm@7.0.26, @storybook/addons@7.0.24, @storybook/mdx1-csf@1.0.0

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
New author assert 2.1.0
New author react 18.2.0
New author react-dom 18.2.0
New author scheduler 0.23.0
New author hasown 2.0.0
New author handlebars 4.7.8
New author get-stream 8.0.1
Shell access foreground-child 3.1.1
Uses eval @sinclair/typebox 0.27.8
Uses eval @storybook/addon-actions 8.0.0-alpha.10
Uses eval @storybook/addon-links 8.0.0-alpha.10
Uses eval @storybook/manager 8.0.0-alpha.10
Uses eval @storybook/preview 8.0.0-alpha.10

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

What is eval?

Package uses eval() which is a dangerous function. This prevents the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Avoid packages that use eval, since this could potentially execute any code.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore @sinclair/typebox@0.27.8
  • @SocketSecurity ignore @storybook/addon-actions@8.0.0-alpha.10
  • @SocketSecurity ignore @storybook/addon-links@8.0.0-alpha.10
  • @SocketSecurity ignore @storybook/manager@8.0.0-alpha.10
  • @SocketSecurity ignore @storybook/preview@8.0.0-alpha.10
  • @SocketSecurity ignore assert@2.1.0
  • @SocketSecurity ignore react@18.2.0
  • @SocketSecurity ignore react-dom@18.2.0
  • @SocketSecurity ignore scheduler@0.23.0
  • @SocketSecurity ignore hasown@2.0.0
  • @SocketSecurity ignore handlebars@4.7.8
  • @SocketSecurity ignore get-stream@8.0.1
  • @SocketSecurity ignore foreground-child@3.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant