build: make copy-to-clipboard an explicit dependency #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When using this plugin inside a yarn 2 project, an error message is thrown because
copy-to-clipboard
was referenced even though it's not part of the package's dependencies.addon-knobs/src/components/Panel.tsx
Line 6 in 1270182
Project owners can manually install copy-to-clipboard themselves, but including it within the library should saves people from an extra error message.
Notes
copy-to-clipboard
currently in the mainline storybook branch. https://github.com/storybookjs/storybook/blob/3c076a333a122feeb07af520c28195358bab68ba/lib/ui/package.json#L54 . I think this import is why the library works indirectly (the issue just wasn't flagged until using yarn 2, since it's stricter about imports).