Update storybook in examples #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 19, 2021
|
We've been fixing bugs right and left in the beta, so I'd recommend updating again. I expect things to stabilize this week 🤞 |
|
I've updated to the latest, but storybookjs/storybook#15574 still seems to be a problem, and the stories are sorted alphabetically. On my own project, I've noticed that the stories in the sidebar start out in the correct order, but then once the preview pane actually renders in, they re-organize into alphabetical order. I'm not sure why. |
|
I'll look at it this week |
|
Going to land this one, and we can upgrade again once there's a fix out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates our examples to use storybook 6.4.0-beta.14.
One regression I've noticed so far is that the stories are no longer sorted by the export order, but rather alphabetically. I haven't traced that down to a particular storybook version yet though.
This also uses yarn's
workspace:protocol so we don't need to update them every time we bump the version of the builder. (https://yarnpkg.com/features/workspaces#publishing-workspaces)