Addon-docs: Fix TS false default value in prop table (#9560)

Addon-docs: Fix TS false default value in prop table
storybookjs · Jan 21, 2020 · 1deaeff · 1deaeff · vercel · Jan 21, 2020
2 parents cf20e87 + 54bf0e3
commit 1deaeff
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/examples/cra-ts-kitchen-sink/src/stories/Button.tsx b/examples/cra-ts-kitchen-sink/src/stories/Button.tsx
@@ -10,6 +10,11 @@ interface ButtonProps {
    * Is primary?
    */
   primary?: boolean;
+
+  /**
+   * default is false
+   */
+  secondary: boolean;
 }
 
 /**
@@ -23,4 +28,5 @@ export const Button: FC<ButtonProps> = ({ children, onClick }) => (
 
 Button.defaultProps = {
   primary: true,
+  secondary: false,
 };
diff --git a/lib/components/src/blocks/PropsTable/PropValue.tsx b/lib/components/src/blocks/PropsTable/PropValue.tsx
@@ -75,11 +75,12 @@ const PropSummary: FC<PropSummaryProps> = ({ value }) => {
   const { summary, detail } = value;
 
   const [isOpen, setIsOpen] = useState(false);
-
   // summary is used for the default value
   // below check fixes not displaying default values for boolean typescript vars
   const summaryAsString =
-    summary && typeof summary.toString === 'function' ? summary.toString() : summary;
+    summary !== undefined && summary !== null && typeof summary.toString === 'function'
+      ? summary.toString()
+      : summary;
   if (isNil(detail)) {
     return <PropText text={summaryAsString} />;
   }