Skip to content

Commit

Permalink
Merge pull request #22160 from storybookjs/valentin/fix-tsconfig-reso…
Browse files Browse the repository at this point in the history
…lution-in-nextjs-projects

Fix tsconfig resolution in Nextjs projects
  • Loading branch information
valentinpalkovic authored and shilman committed May 3, 2023
1 parent 3c8b205 commit 4326882
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
10 changes: 8 additions & 2 deletions code/frameworks/nextjs/src/imports/webpack.ts
Expand Up @@ -2,8 +2,14 @@ import TsconfigPathsPlugin from 'tsconfig-paths-webpack-plugin';
import { loadConfig } from 'tsconfig-paths';
import type { Configuration as WebpackConfig } from 'webpack';

export const configureImports = (baseConfig: WebpackConfig): void => {
const configLoadResult = loadConfig();
export const configureImports = ({
baseConfig,
configDir,
}: {
baseConfig: WebpackConfig;
configDir: string;
}): void => {
const configLoadResult = loadConfig(configDir);

if (configLoadResult.resultType === 'failed' || !configLoadResult.baseUrl) {
// either not a typescript project or tsconfig contains no baseUrl
Expand Down
2 changes: 1 addition & 1 deletion code/frameworks/nextjs/src/preset.ts
Expand Up @@ -145,7 +145,7 @@ export const webpackFinal: StorybookConfig['webpackFinal'] = async (baseConfig,
configureNextFont(baseConfig);
configureNextImport(baseConfig);
configureRuntimeNextjsVersionResolution(baseConfig);
configureImports(baseConfig);
configureImports({ baseConfig, configDir: options.configDir });
configureCss(baseConfig, nextConfig);
configureImages(baseConfig);
configureRouting(baseConfig);
Expand Down

0 comments on commit 4326882

Please sign in to comment.