Merge pull request #22085 from storybookjs/shilman/22046-typeof-module

Core: Fix `module` guard in non-webpack environments
storybookjs · Apr 18, 2023 · 5517dac · 5517dac
1 parent 681e1d4
commit 5517dac
Show file tree

Hide file tree

Showing 10 changed files with 10 additions and 10 deletions.
diff --git a/code/frameworks/angular/src/client/index.ts b/code/frameworks/angular/src/client/index.ts
@@ -12,4 +12,4 @@ export type { StoryFnAngularReturnType as IStory } from './types';
 export { moduleMetadata, componentWrapperDecorator, applicationConfig } from './decorators';
 
 // optimization: stop HMR propagation in webpack
-module?.hot?.decline();
+if (typeof module !== 'undefined') module?.hot?.decline();
diff --git a/code/frameworks/ember/src/index.ts b/code/frameworks/ember/src/index.ts
@@ -3,4 +3,4 @@
 export { storiesOf, configure, forceReRender, raw } from './client/preview';
 
 // optimization: stop HMR propagation in webpack
-module?.hot?.decline();
+if (typeof module !== 'undefined') module?.hot?.decline();
diff --git a/code/renderers/html/src/index.ts b/code/renderers/html/src/index.ts
@@ -6,4 +6,4 @@ export * from './public-api';
 export * from './public-types';
 
 // optimization: stop HMR propagation in webpack
-module?.hot?.decline();
+if (typeof module !== 'undefined') module?.hot?.decline();
diff --git a/code/renderers/preact/src/index.ts b/code/renderers/preact/src/index.ts
@@ -6,4 +6,4 @@ export * from './public-api';
 export * from './public-types';
 
 // optimization: stop HMR propagation in webpack
-module?.hot?.decline();
+if (typeof module !== 'undefined') module?.hot?.decline();
diff --git a/code/renderers/react/src/index.ts b/code/renderers/react/src/index.ts
@@ -8,4 +8,4 @@ export * from './public-types';
 export * from './testing-api';
 
 // optimization: stop HMR propagation in webpack
-module?.hot?.decline();
+if (typeof module !== 'undefined') module?.hot?.decline();
diff --git a/code/renderers/server/src/index.ts b/code/renderers/server/src/index.ts
@@ -6,4 +6,4 @@ export * from './public-api';
 export * from './public-types';
 
 // optimization: stop HMR propagation in webpack
-module?.hot?.decline();
+if (typeof module !== 'undefined') module?.hot?.decline();
diff --git a/code/renderers/svelte/src/index.ts b/code/renderers/svelte/src/index.ts
@@ -6,4 +6,4 @@ export * from './public-api';
 export * from './public-types';
 
 // optimization: stop HMR propagation in webpack
-module?.hot?.decline();
+if (typeof module !== 'undefined') module?.hot?.decline();
diff --git a/code/renderers/vue/src/index.ts b/code/renderers/vue/src/index.ts
@@ -6,4 +6,4 @@ export * from './public-api';
 export * from './public-types';
 
 // optimization: stop HMR propagation in webpack
-module?.hot?.decline();
+if (typeof module !== 'undefined') module?.hot?.decline();
diff --git a/code/renderers/vue3/src/index.ts b/code/renderers/vue3/src/index.ts
@@ -6,4 +6,4 @@ export * from './public-api';
 export * from './public-types';
 
 // optimization: stop HMR propagation in webpack
-module?.hot?.decline();
+if (typeof module !== 'undefined') module?.hot?.decline();
diff --git a/code/renderers/web-components/src/index.ts b/code/renderers/web-components/src/index.ts
@@ -11,7 +11,7 @@ export * from './public-api';
 export * from './framework-api';
 
 // TODO: disable HMR and do full page loads because of customElements.define
-if (module && module.hot && module.hot.decline) {
+if (typeof module !== 'undefined' && module?.hot?.decline) {
   module.hot.decline();
 
   // forcing full reloads for customElements as elements can only be defined once per page