Merge pull request #12081 from storybookjs/fix-12070-angular-cli-stor…

…y-templates Angular: Make CLI templates compatible with TS strict mode
storybookjs · Aug 17, 2020 · 57e614b · 57e614b
2 parents 5898887 + 37318e9
commit 57e614b
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/lib/cli/src/frameworks/angular/button.component.ts b/lib/cli/src/frameworks/angular/button.component.ts
@@ -17,13 +17,13 @@ export default class ButtonComponent {
    * Is this the principal call to action on the page?
    */
   @Input()
-  primary: boolean;
+  primary = false;
 
   /**
    * What background color to use
    */
   @Input()
-  backgroundColor: string;
+  backgroundColor?: string;
 
   /**
    * How large should the button be?
@@ -37,7 +37,7 @@ export default class ButtonComponent {
    * @required
    */
   @Input()
-  label: string;
+  label = 'Button';
 
   /**
    * Optional click handler

diff --git a/lib/cli/src/frameworks/angular/header.component.ts b/lib/cli/src/frameworks/angular/header.component.ts
@@ -50,7 +50,7 @@ import { Component, Input, Output, EventEmitter } from '@angular/core';
 })
 export default class HeaderComponent {
   @Input()
-  user = null;
+  user: unknown = null;
 
   @Output()
   onLogin = new EventEmitter<Event>();

diff --git a/lib/cli/src/frameworks/angular/page.component.ts b/lib/cli/src/frameworks/angular/page.component.ts
@@ -63,7 +63,7 @@ import { Component, Input, Output, EventEmitter } from '@angular/core';
 })
 export default class PageComponent {
   @Input()
-  user = null;
+  user: unknown = null;
 
   @Output()
   onLogin = new EventEmitter<Event>();

diff --git a/scripts/run-e2e-config.ts b/scripts/run-e2e-config.ts
@@ -17,7 +17,7 @@ const baseAngular: Parameters = {
   version: 'latest',
   generator: [
     `yarn add @angular/cli@{{version}} --no-lockfile --non-interactive --silent --no-progress`,
-    `npx ng new {{name}}-{{version}} --routing=true --minimal=true --style=scss --skipInstall=true`,
+    `npx ng new {{name}}-{{version}} --routing=true --minimal=true --style=scss --skipInstall=true --strict`,
   ].join(' && '),
   additionalDeps: ['react', 'react-dom'],
 };