Merge pull request #21962 from storybookjs/jpzwarte/fix-viewport-defa…

…ult-orientation Viewport: Fix the `defaultOrientation` config option
storybookjs · Apr 6, 2023 · 71b2046 · 71b2046
2 parents e3bc173 + c1f4580
commit 71b2046
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/code/addons/viewport/src/Tool.tsx b/code/addons/viewport/src/Tool.tsx
@@ -155,9 +155,9 @@ export const ViewportTool: FC = memo(
       setState({
         selected:
           defaultViewport || (viewports[state.selected] ? state.selected : responsiveViewport.id),
-        isRotated: state.isRotated,
+        isRotated: defaultOrientation === 'landscape',
       });
-    }, [defaultViewport]);
+    }, [defaultOrientation, defaultViewport]);
 
     const { selected, isRotated } = state;
     const item =

diff --git a/code/addons/viewport/template/stories/parameters.stories.ts b/code/addons/viewport/template/stories/parameters.stories.ts
@@ -26,6 +26,15 @@ export const Selected = {
   },
 };
 
+export const Orientation = {
+  parameters: {
+    viewport: {
+      defaultViewport: Object.keys(MINIMAL_VIEWPORTS)[0],
+      defaultOrientation: 'landscape',
+    },
+  },
+};
+
 export const Custom = {
   parameters: {
     viewport: {