WIP: add sandbox for angular 16

storybookjs · Apr 14, 2023 · 9549ab3 · 9549ab3
1 parent ccd32b5
commit 9549ab3
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 2 deletions.
diff --git a/code/frameworks/angular/package.json b/code/frameworks/angular/package.json
@@ -92,7 +92,7 @@
   },
   "peerDependencies": {
     "@angular-devkit/architect": ">=0.1400.0 < 0.1600.0",
-    "@angular-devkit/build-angular": ">=14.1.0 < 16.0.0",
+    "@angular-devkit/build-angular": ">=14.1.0 < 17.0.0",
     "@angular-devkit/core": ">=14.1.0 < 16.0.0",
     "@angular/cli": ">=14.1.0 < 16.0.0",
     "@angular/common": ">=14.1.0 < 16.0.0",

diff --git a/code/lib/cli/src/sandbox-templates.ts b/code/lib/cli/src/sandbox-templates.ts
@@ -266,6 +266,28 @@ const baseTemplates = {
     // Remove smoke-test from the list once https://github.com/storybookjs/storybook/issues/19351 is fixed.
     skipTasks: ['smoke-test', 'e2e-tests-dev'],
   },
+  'angular-cli/16-ts': {
+    name: 'Angular CLI (Version 16)',
+    script:
+      'npx -p @angular/cli@next ng new angular-v16 --directory . --routing=true --minimal=true --style=scss --strict --skip-git --skip-install --package-manager=yarn',
+    expected: {
+      framework: '@storybook/angular',
+      renderer: '@storybook/angular',
+      builder: '@storybook/builder-webpack5',
+    },
+    skipTasks: ['e2e-tests-dev'],
+    modifications: {
+      mainConfig: {
+        framework: {
+          name: '@storybook/angular',
+          options: {
+            enableNgcc: false,
+          },
+        },
+      },
+    },
+    inDevelopment: true,
+  },
   'angular-cli/default-ts': {
     name: 'Angular CLI (latest)',
     script:
@@ -459,6 +481,8 @@ export const allTemplates: Record<TemplateKey, Template> = {
 export const ci: TemplateKey[] = ['cra/default-ts', 'react-vite/default-ts'];
 export const pr: TemplateKey[] = [
   ...ci,
+  // TODO: add this after the sandbox is ready in the sandboxes repo
+  // 'angular-cli/16-ts',
   'angular-cli/default-ts',
   'vue3-vite/default-ts',
   'vue-cli/vue2-default-js',

diff --git a/code/yarn.lock b/code/yarn.lock
@@ -5561,7 +5561,7 @@ __metadata:
     zone.js: ^0.12.0
   peerDependencies:
     "@angular-devkit/architect": ">=0.1400.0 < 0.1600.0"
-    "@angular-devkit/build-angular": ">=14.1.0 < 16.0.0"
+    "@angular-devkit/build-angular": ">=14.1.0 < 17.0.0"
     "@angular-devkit/core": ">=14.1.0 < 16.0.0"
     "@angular/cli": ">=14.1.0 < 16.0.0"
     "@angular/common": ">=14.1.0 < 16.0.0"