Skip to content

Commit

Permalink
Remove react and react-dom from required deps in E2E test configs
Browse files Browse the repository at this point in the history
They are now regular deps of SB packages for all non-react app so there is no more need to add them explicitly.
  • Loading branch information
gaetanmaisse committed Nov 2, 2020
1 parent 89d0ed9 commit b1a0f4b
Showing 1 changed file with 1 addition and 11 deletions.
12 changes: 1 addition & 11 deletions scripts/run-e2e-config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ const baseAngular: Parameters = {
`yarn add @angular/cli@{{version}} --no-lockfile --non-interactive --silent --no-progress`,
`yarn ng new {{name}}-{{version}} --routing=true --minimal=true --style=scss --skipInstall=true --strict`,
].join(' && '),
additionalDeps: ['react', 'react-dom'],
};

// export const angularv6: Parameters = {
Expand All @@ -44,7 +43,7 @@ const baseAngular: Parameters = {
export const angularv9: Parameters = {
...baseAngular,
version: 'v9-lts',
additionalDeps: [...baseAngular.additionalDeps, 'core-js'],
additionalDeps: ['core-js'],
};

export const angular: Parameters = baseAngular;
Expand All @@ -63,7 +62,6 @@ export const html: Parameters = {
version: 'latest',
generator: fromDeps(),
autoDetect: false,
additionalDeps: ['react', 'react-dom'],
};

// TODO: broken
Expand Down Expand Up @@ -95,7 +93,6 @@ export const mithril: Parameters = {
name: 'mithril',
version: 'latest',
generator: fromDeps('mithril@{{version}}'),
additionalDeps: ['react', 'react-dom'],
};

export const preact: Parameters = {
Expand All @@ -104,15 +101,13 @@ export const preact: Parameters = {
generator:
'npx preact-cli@{{version}} create preactjs-templates/default {{name}}-{{version}} --yarn --install=false --git=false',
ensureDir: false,
additionalDeps: ['react', 'react-dom'],
};

export const rax: Parameters = {
name: 'rax',
version: 'latest',
// Rax versions are inconsistent 1.1.0-1 for some
generator: fromDeps('rax', 'rax-image', 'rax-link', 'rax-text', 'rax-view'),
additionalDeps: ['react', 'react-dom'],
};

export const react: Parameters = {
Expand Down Expand Up @@ -163,8 +158,6 @@ export const sfcVue: Parameters = {
version: 'latest',
generator: fromDeps('vue', 'vue-loader', 'vue-template-compiler'),
additionalDeps: [
'react',
'react-dom',
'webpack@webpack-4',
// TODO: remove when https://github.com/storybookjs/storybook/issues/11255 is solved
'core-js',
Expand All @@ -175,21 +168,18 @@ export const svelte: Parameters = {
name: 'svelte',
version: 'latest',
generator: 'npx degit sveltejs/template {{name}}-{{version}}',
additionalDeps: ['react', 'react-dom'],
};

export const vue: Parameters = {
name: 'vue',
version: 'latest',
generator: `npx @vue/cli@{{version}} create {{name}}-{{version}} --default --packageManager=yarn --no-git --force`,
additionalDeps: ['react', 'react-dom'],
};

export const web_components: Parameters = {
name: 'web_components',
version: 'latest',
generator: fromDeps('lit-html', 'lit-element'),
additionalDeps: ['react', 'react-dom'],
};

export const webpack_react: Parameters = {
Expand Down

0 comments on commit b1a0f4b

Please sign in to comment.